Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| @@ -62,7 +62,7 @@ | |||
| <div class="h-0.5 rounded-full bg-inverse"></div> | |||
| <WorkflowDetail | |||
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| content={workflow?.taskQueue} | ||
| href={routeForWorkers({ | ||
| href={routeForWorkflowWorkers({ | ||
| namespace: $page.params.namespace, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| href={routeForWorkers({ | ||
| href={routeForWorkflowWorkers({ | ||
| namespace: $page.params.namespace, | ||
| workflow: workflow?.id, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| <DropdownFilterChip | ||
| filter={activityFilter} | ||
| filter={filterItem} | ||
| index={i} |
Contributor
There was a problem hiding this comment.
⚠️ Type 'number | null' is not assignable to type 'number | undefined'.
| @@ -131,8 +138,9 @@ | |||
| onclick={() => { | |||
| handleNewQuery(value, type); | |||
| }} | |||
Contributor
There was a problem hiding this comment.
⚠️ Type 'boolean | "" | undefined' is not assignable to type 'boolean | undefined'.
| !localFilters[0].value && | ||
| status === 'All')} | ||
| <MenuItem | ||
| data-testid={`status-dropdown-filter-chip-${status}`} |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'string | null' is not assignable to parameter of type 'string'.
| onclick={() => handleStatusSelect(status)} | ||
| > | ||
| {#snippet leading()} | ||
| <Checkbox |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'string | null' is not assignable to parameter of type 'string'.
| {#snippet leading()} | ||
| <Checkbox | ||
| on:change={() => handleStatusSelect(status)} | ||
| {checked} |
Contributor
There was a problem hiding this comment.
⚠️ Type '"All" | "Unspecified" | "Running" | "Completed" | "Canceled" | "Failed" | "Terminated" | "Paused" | "TimedOut" | "ContinuedAsNew" | "ShuttingDown" | null' is not assignable to type 'string | undefined'.
| /> | ||
| <WorkersTableCell copyable={false}> | ||
| <SdkLogo | ||
| sdk={formatSDKName(worker.workerHeartbeat.sdkName)} |
Contributor
There was a problem hiding this comment.
⚠️ 'worker.workerHeartbeat' is possibly 'null' or 'undefined'.⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
|
|
||
| <PaginatedTable | ||
| let:visibleItems | ||
| {onFetch} |
Contributor
There was a problem hiding this comment.
⚠️ Type '((err: APIErrorResponse) => void) | undefined' is not assignable to type '((error: unknown) => void | undefined) | undefined'.
| {#each columns as { label } (label)} | ||
| <th>{label}</th> | ||
| {/each} | ||
| </tr> |
Contributor
There was a problem hiding this comment.
⚠️ 'worker.workerHeartbeat' is possibly 'null' or 'undefined'.
| request, | ||
| params: { | ||
| maximumPageSize: String(pageSize), | ||
| nextPageToken: token, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
| </div> | ||
| </div> | ||
| </header> | ||
| {#await describeWorker({ namespace, workerInstanceKey }) then data} |
Contributor
There was a problem hiding this comment.
⚠️ Type 'IWorkerInfo | null | undefined' is not assignable to type 'IWorkerInfo'.
| @@ -175,7 +174,6 @@ | |||
| </div> | |||
| <CodecServerErrorBanner /> | |||
Contributor
There was a problem hiding this comment.
⚠️ Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
| let { worker }: Props = $props(); | ||
|
|
||
| const { namespace } = $derived(page.params); | ||
| const heartbeat = $derived(worker.workerHeartbeat); |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'WorkerStatus | null | undefined' is not assignable to parameter of type 'WorkerStatus | undefined'.
| > | ||
| <Copyable | ||
| copyIconTitle={translate('common.copy-icon-title')} | ||
| copySuccessIconTitle={translate('common.copy-success-icon-title')} |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
| <DetailListColumn> | ||
| <DetailListLabel>{translate('common.task-queue')}</DetailListLabel> | ||
| <DetailListLinkValue | ||
| copyable |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
| <DetailListColumn> | ||
| <DetailListLabel>{translate('workers.sdk')}</DetailListLabel> | ||
| <DetailListValue> | ||
| <SdkLogo |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'string | null | undefined' is not assignable to parameter of type 'string | undefined'.
| <DetailListLabel>{translate('workers.sdk')}</DetailListLabel> | ||
| <DetailListValue> | ||
| <SdkLogo | ||
| sdk={formatSDKName(heartbeat?.sdkName)} |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
| {slots.currentUsedSlots ?? 0} | ||
| </p> | ||
| <p class="font-mono text-2xl font-semibold"> | ||
| {#if slots.currentAvailableSlots} |
Contributor
There was a problem hiding this comment.
⚠️ 'slots.currentUsedSlots' is possibly 'null' or 'undefined'.
| <span class="flex items-center gap-1 font-semibold"> | ||
| <Icon name="microchip" class="h-3 w-3 text-secondary" /> | ||
| {translate('workers.cpu-usage')} | ||
| </span> |
Contributor
There was a problem hiding this comment.
⚠️ 'heartbeat.hostInfo.currentHostCpuUsage' is possibly 'null' or 'undefined'.
| <div class="relative h-2 w-full overflow-hidden rounded bg-indigo-100"> | ||
| <div | ||
| class="absolute left-0 flex h-full items-center bg-indigo-600" | ||
| style="width:{Math.min( |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'number | null | undefined' is not assignable to parameter of type 'number'.
| <span class="flex items-center gap-1 font-semibold"> | ||
| <Icon name="server" class="h-3 w-3 text-secondary" /> | ||
| {translate('workers.memory-usage')} | ||
| </span> |
Contributor
There was a problem hiding this comment.
⚠️ 'heartbeat.hostInfo.currentHostMemUsage' is possibly 'null' or 'undefined'.
| <div class="relative h-2 w-full overflow-hidden rounded bg-indigo-100"> | ||
| <div | ||
| class="absolute left-0 flex h-full items-center bg-indigo-600" | ||
| style="width:{Math.min( |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'number | null | undefined' is not assignable to parameter of type 'number'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?